Skip to content

update progress bar for element internals#14

Merged
chrisdholt merged 3 commits into
chrisdholt:users/chhol/update-progress-bar-for-element-internalsfrom
radium-v:users/chhol/update-progress-bar-for-element-internals
Jun 11, 2024
Merged

update progress bar for element internals#14
chrisdholt merged 3 commits into
chrisdholt:users/chhol/update-progress-bar-for-element-internalsfrom
radium-v:users/chhol/update-progress-bar-for-element-internals

Conversation

@radium-v

Copy link
Copy Markdown

Previous Behavior

  • Tests were synchronous
  • Explicit calls were needed to update the percentComplete
  • ARIA properties were being set in multiple places

New Behavior

  • Tests are async
  • percentComplete is now marked with @volatile, so any changes to properties used by it get set when those properties change
  • ARIA properties are automatically set when attributes change, and only when necessary

@chrisdholt chrisdholt merged commit 4035b73 into chrisdholt:users/chhol/update-progress-bar-for-element-internals Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants