Conversation
Change the `x or y +1` into `max(x or y, 1)` for texture size calculation in texture replacement. The +1 was to avoid 0 width/height textures but the max does this in a way that actually makes sense. Closes #1505
lahm86
reviewed
Oct 17, 2025
Collaborator
lahm86
left a comment
lahm86
left a comment
There was a problem hiding this comment.
I think there is still an issue in slinc.tr2 room 18 with animated on, but maybe it's just a bad texture to begin with? Not sure what it's like in-game.
lahm86
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the
x or y +1intomax(x or y, 1)for texture size calculation in texture replacement.The +1 was to avoid 0 width/height textures but the max does this in a way that actually makes sense.
Closes #1505