Conversation
Simplify remote call Portal neighbours, remove ceiling step wall check Add rooms from portals as neighbours. Remove check for wall in ceiling steps Follow more levels of portal Sample at half block intervals Start slightly below half height too Fix ladder ceiling step using wrong direction E<>W
Now we have the full list of portals we can choose the right one and ignore the distant ones.
Still need step ups and downs in that case
Don't try to step up into ceilings above Also add remote quads to alternate rooms
Almost fix face generation, almost.
lahm86
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More or less rewrite the geometry mode mesh generation to fix the issues with it.
Now that all the portal information is present (from #1496 being fixed) this can be done properly without all the weird hacks that were there before.
This doesn't solve absolutely every problem. There's still one known problem in joby3a. Can make a separate issue to track this.


Potential issue in triboss, though not sure:
Closes #1131