Add placeholder mesh for item with no visible mesh #1462
Merged
Conversation
Add a placeholder mesh that will show in some cases where the item is invisible. This doesn't cover all cases, just a few more common ones. In future might want to have transparency toggleable on meshes so full invisible meshes can become visible. Closes #1203
lahm86
reviewed
Aug 23, 2025
Collaborator
lahm86
left a comment
lahm86
left a comment
There was a problem hiding this comment.
Looks great.
I get a crash in debug when hovering over it however:
Owner
Author
Yes I noticed this too, the direction vector for the pick isn't normalised - it should be. However normalising it seems to break how picking works currently, you get weird pick orders. Going to fix it separately and figure out what's going on. That's a debug assertion so only gets checked in debug, if you press ignore it will continue but it's not very convenient because it will just check again next frame. |
lahm86
approved these changes
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a placeholder mesh that will show in some cases where the item is invisible.
This doesn't cover all cases, just a few more common ones.
In future might want to have transparency toggleable on meshes so full invisible meshes can become visible.
Closes #1203