Merged
Conversation
Render default cube mesh for flyby nodes Moving camera around Control camera from flyby window Tests, rolling Update Flyby.cpp Catmull rom pos, target Also fov and roll. Initial camera states need to be restored after playback. Update Flyby.cpp Start updating state Update a state instead of being stateless Implement bit 7 Rearrange state Index Flags, other values Show flags, timer, speed, room Flag names Add the frustum mesh Fix roll for nodes Restyle slider to be the bar WIP on flybys
Generate the flyby path Only render flyby if cameras are visible
Jump to next camera in path
Filterable etc
lahm86
reviewed
Aug 2, 2025
Collaborator
lahm86
left a comment
lahm86
left a comment
There was a problem hiding this comment.
Very nice! Works really well. Just a few queries below.
I suppose it would be nice too if when you click on a trigger for a flyby, that it takes you to its first node in the view (similar to clicking a camera trigger). But that could be a future enhancement.
Owner
Author
Yes I forgot this - also this made me notice that the sequences aren't always 0, 1, 2... so I will show that number too |
Take the sequence number from the first camera node if present #1443
Show the flyby number on pick hover Uncomment commented code (diff support)
lahm86
approved these changes
Aug 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add flyby cameras and flyby playback.
Flyby cameras appear in the world showing the path that the camera will take.
Flyby cameras are shown in the camera/sink window and the flyby can be played back to show an approximation of how it will appear in-game.
Closes #1443