Skip to content

Use std::span function to fix build break#1442

Merged
chreden merged 5 commits intomasterfrom
issue/1441
Jun 5, 2025
Merged

Use std::span function to fix build break#1442
chreden merged 5 commits intomasterfrom
issue/1441

Conversation

@chreden
Copy link
Owner

@chreden chreden commented Jun 5, 2025

After a VS update the creation of ispanstream has failed again.
Change to using the std::span function.
Closes #1441

After a VS update the creation of ispanstream can go back to not needing a temporary any more. The temporary was added because this same code broke in a previous VS update. This essentially puts it back to how it was.
#1441
@chreden chreden added this to the Next milestone Jun 5, 2025
@chreden chreden requested review from lahm86 and makotocchi June 5, 2025 19:08
@chreden chreden self-assigned this Jun 5, 2025
@chreden chreden added the build label Jun 5, 2025
@chreden
Copy link
Owner Author

chreden commented Jun 5, 2025

Agents are probably on an older version of VS. Will see if there's anything I can do.

@chreden chreden changed the title Revert ispanstream fix Use std::span function to fix build break Jun 5, 2025
@chreden chreden merged commit 1ace64f into master Jun 5, 2025
1 check passed
@chreden chreden deleted the issue/1441 branch June 5, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple C2440 errors when Building

2 participants