Correctly offset room sprites based on their size#1415
Merged
Conversation
Room sprite offset was assuming that sprites were had equal size on either side of the centre y. Take into account sprite like the dangling vines that need to be moved up, not down. Closes #1414
lahm86
reviewed
May 16, 2025
trview.app/Geometry/IMesh.cpp
Outdated
| if (offset_mode == SpriteOffsetMode::RoomSprite) | ||
| { | ||
| offset = Vector3(0, (1 - object_height) * 0.5f, 0); | ||
| const float y_factor = (-0.5f + ((fabs(static_cast<float>(top)) / (bottom - top)))); |
Collaborator
There was a problem hiding this comment.
Worth a guard in case bottom == top? Just thinking of TRLE world.
Owner
Author
There was a problem hiding this comment.
Good idea, not sure why they'd do that but good to avoid the div by 0
lahm86
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Room sprite offset was assuming that sprites were had equal size on either side of the centre y.
Take into account sprite like the dangling vines that need to be moved up, not down and not just by half the object height.
Closes #1414