Add filter for 'Extra' value to Triggers window#1410
Merged
Conversation
Add a multi-getter trigger to the triggers window that filters on the 'Extra' data that cameras and a couple of other commands have. Since the triggers window is filtering on triggers and not on commands all of the extras are joined and that is what is queries - for example if a trigger has two commands, one with 255 and one with 256 the trigger will have extra value of [255, 256] and will match both. Closes #1409
lahm86
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a multi-getter trigger to the triggers window that filters on the 'Extra' data that cameras and a couple of other commands have.
Since the triggers window is filtering on triggers and not on commands all of the extras are joined and that is what is queried - for example if a trigger has two commands, one with 255 and one with 256 the trigger will have extra value of [255, 256] and will match both.
Closes #1409