Skip to content

Context menu option to filter to items on a tile#1333

Merged
chreden merged 6 commits intomasterfrom
issue/167
Dec 28, 2024
Merged

Context menu option to filter to items on a tile#1333
chreden merged 6 commits intomasterfrom
issue/167

Conversation

@chreden
Copy link
Owner

@chreden chreden commented Dec 26, 2024

Add an option to the context menu to filter an items window to only show items on the same tile.
Closes #167

@chreden chreden changed the title Issue/167 Context menu option to filter to items on a tile Dec 28, 2024
@chreden chreden self-assigned this Dec 28, 2024
@chreden chreden added this to the Next milestone Dec 28, 2024
@chreden chreden marked this pull request as ready for review December 28, 2024 13:04
@lahm86
Copy link
Collaborator

lahm86 commented Dec 28, 2024

Looks good. I've noticed if I re-use a window, it doesn't clear the previous filter. For example, filter a tile with an item first, then do the same on a different tile and pick "Items 1" as the window.

image

It's similar if I've set a filter manually on a window, then chosen that window for a tile filter.

image

I suppose it should just clear the current filter, or is it able to do an OR? I guess not without nesting.

@chreden
Copy link
Owner Author

chreden commented Dec 28, 2024

Looks good. I've noticed if I re-use a window, it doesn't clear the previous filter. For example, filter a tile with an item first, then do the same on a different tile and pick "Items 1" as the window.

image

It's similar if I've set a filter manually on a window, then chosen that window for a tile filter.

image

I suppose it should just clear the current filter, or is it able to do an OR? I guess not without nesting.

I did leave it as an add as I thought it would be useful to add to a query you were already building but I suppose in most cases a clear and set would actually be more useful, at least less wrong.

Yes nesting would need a bit more work but would be good to have at some point.

I'll change it to set.

@chreden chreden merged commit afcb067 into master Dec 28, 2024
@chreden chreden deleted the issue/167 branch December 28, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List items on a square

2 participants