(#548) Remove creation of Chocolatey Install Directory#549
Merged
AdmiringWorm merged 1 commit intochocolatey:hotfix/3.0.3from Oct 6, 2023
Merged
(#548) Remove creation of Chocolatey Install Directory#549AdmiringWorm merged 1 commit intochocolatey:hotfix/3.0.3from
AdmiringWorm merged 1 commit intochocolatey:hotfix/3.0.3from
Conversation
This commit removes the manal creation of the Chocolatey CLI directory where the application will be installed to. This is done as a change in the Chocolatey CLI script have changed so that if the directory exists, Chocolatey CLI will fail to install. This manual creation may have been needed some time in the past, but has not been needed for several years now. We should not create anything that is not needed to be created, and rely on the installation script instead to know what to set up for its own installation.
9dec9ec to
8ab6cb8
Compare
mwallner
approved these changes
Oct 5, 2023
Member
Author
|
Thank you for approving the PR @mwallner. As it was approved, I'll get it merged into the hotfix branch we have for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This commit removes the manal creation of the Chocolatey CLI directory
where the application will be installed to.
This is done as a change in the Chocolatey CLI script have changed so
that if the directory exists, Chocolatey CLI will fail to install.
This manual creation may have been needed some time in the past, but has
not been needed for several years now.
Motivation and Context
We should not create anything that is not needed to be created, and rely
on the installation script instead to know what to set up for its own
installation.
Testing
Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; . "<PATH_TO_BOOTSTRAPPER>"; Get-Boxstarter -Force(Replace<PATH_TO_BOOTSTRAPPER>with the path to the location you copied the script.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #548