builtin/: add UNLEAKs

Martin Ågren · gitster · commit 886e1084d78c · 2017-10-02T13:03:10.000+09:00
Add some UNLEAKs where we are about to return from `cmd_*`. UNLEAK the
variables in the same order as we've declared them. While addressing
`msg` in builtin/tag.c, convert the existing `strbuf_release()` calls as
well.

Signed-off-by: Martin Ågren &lt;martin.agren@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/checkout.c b/builtin/checkout.c
@@ -1291,6 +1291,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
 		strbuf_release(&buf);
 	}
 
+	UNLEAK(opts);
 	if (opts.patch_mode || opts.pathspec.nr)
 		return checkout_paths(&opts, new.name);
 	else
diff --git a/builtin/diff-index.c b/builtin/diff-index.c
@@ -57,5 +57,6 @@ int cmd_diff_index(int argc, const char **argv, const char *prefix)
 		return -1;
 	}
 	result = run_diff_index(&rev, cached);
+	UNLEAK(rev);
 	return diff_result_code(&rev.diffopt, result);
 }
diff --git a/builtin/diff.c b/builtin/diff.c
@@ -466,5 +466,8 @@ int cmd_diff(int argc, const char **argv, const char *prefix)
 	result = diff_result_code(&rev.diffopt, result);
 	if (1 < rev.diffopt.skip_stat_unmatch)
 		refresh_index_quietly();
+	UNLEAK(rev);
+	UNLEAK(ent);
+	UNLEAK(blob);
 	return result;
 }
diff --git a/builtin/name-rev.c b/builtin/name-rev.c
@@ -494,5 +494,6 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
 				  always, allow_undefined, data.name_only);
 	}
 
+	UNLEAK(revs);
 	return 0;
 }
diff --git a/builtin/tag.c b/builtin/tag.c
@@ -552,9 +552,10 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 	if (force && !is_null_oid(&prev) && oidcmp(&prev, &object))
 		printf(_("Updated tag '%s' (was %s)\n"), tag, find_unique_abbrev(prev.hash, DEFAULT_ABBREV));
 
-	strbuf_release(&err);
-	strbuf_release(&buf);
-	strbuf_release(&ref);
-	strbuf_release(&reflog_msg);
+	UNLEAK(buf);
+	UNLEAK(ref);
+	UNLEAK(reflog_msg);
+	UNLEAK(msg);
+	UNLEAK(err);
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -1291,6 +1291,7 @@ int cmd_checkout(int argc, const char *argv, const char prefix)`
`1291`	`1291`	`strbuf_release(&buf);`
`1292`	`1292`	`}`
`1293`	`1293`
	`1294`	`+ UNLEAK(opts);`
`1294`	`1295`	`if (opts.patch_mode \|\| opts.pathspec.nr)`
`1295`	`1296`	`return checkout_paths(&opts, new.name);`
`1296`	`1297`	`else`
Original file line number	Diff line number	Diff line change
`@@ -57,5 +57,6 @@ int cmd_diff_index(int argc, const char *argv, const char prefix)`
`57`	`57`	`return -1;`
`58`	`58`	`}`
`59`	`59`	`result = run_diff_index(&rev, cached);`
	`60`	`+ UNLEAK(rev);`
`60`	`61`	`return diff_result_code(&rev.diffopt, result);`
`61`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -466,5 +466,8 @@ int cmd_diff(int argc, const char *argv, const char prefix)`
`466`	`466`	`result = diff_result_code(&rev.diffopt, result);`
`467`	`467`	`if (1 < rev.diffopt.skip_stat_unmatch)`
`468`	`468`	`refresh_index_quietly();`
	`469`	`+ UNLEAK(rev);`
	`470`	`+ UNLEAK(ent);`
	`471`	`+ UNLEAK(blob);`
`469`	`472`	`return result;`
`470`	`473`	`}`
Original file line number	Diff line number	Diff line change
`@@ -494,5 +494,6 @@ int cmd_name_rev(int argc, const char *argv, const char prefix)`
`494`	`494`	`always, allow_undefined, data.name_only);`
`495`	`495`	`}`
`496`	`496`
	`497`	`+ UNLEAK(revs);`
`497`	`498`	`return 0;`
`498`	`499`	`}`