Skip to content

Conversation

@Siudya
Copy link
Contributor

@Siudya Siudya commented Dec 26, 2025

Use "\\" in verification directory path on Windows platform, instead of "\". The issue llvm/circt#9327 described the problem.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Fix verification directory path strings on Windows platform

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 26, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Siudya / name: 梁森 Liang Sen (efb2ba2)

@Siudya Siudya force-pushed the fix-windows branch 2 times, most recently from aa661f3 to 9227121 Compare December 26, 2025 05:07
@seldridge seldridge added the Bugfix Fixes a bug, will be included in release notes label Dec 26, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This just needs to have formatting run on it:

./mill '__.reformat'   

@Siudya
Copy link
Contributor Author

Siudya commented Dec 26, 2025

LGTM

This just needs to have formatting run on it:

./mill '__.reformat'   

Done.

@seldridge seldridge merged commit 5c6f749 into chipsalliance:main Dec 26, 2025
17 checks passed
@Siudya Siudya deleted the fix-windows branch December 28, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a bug, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants