Add runpath option to UnitTests main #5125
Merged
+69
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jackkoenig Can we somehow waive the binary compatibility check? This touches APIs that have only seen experimental use so far an shouldn't break any real-world code. |
seldridge
approved these changes
Dec 16, 2025
| try { | ||
| url.openConnection.setDefaultUseCaches(false) | ||
| } catch { | ||
| case e: IOException => // just ignore these |
Contributor
Author
There was a problem hiding this comment.
Taken verbatim from scalatest. I think they just do this on a best-effort basis. Like everything in scalatest.
fabianschuiki
force-pushed
the
fschuiki/unit-test-runpath
branch
2 times, most recently
from
114c193 to
42b7f41
Compare
Contributor
Author
|
How can I merge this ignoring the binary compatibility check? |
Contributor
You need to add waivers here: Line 63 in 3499961 Of the style: There might be a way to waive all types of problems with one ProblemFilter, I'm not sure You can test this with: |
Contributor
Author
|
Oh nice, thanks a lot! 🎖️ |
Add a `-R` option to the `chisel3.UnitTests` main class which mirrors the same option in scalatest's runner. This option allows the user to supply a reduced classpath to be searched for Chisel unit test classes. This allows discovery to be much faster in larger projects with many dependencies, since the classpath contains all dependencies, but the runpath can be limited to discover only test of the current project.
fabianschuiki
force-pushed
the
fschuiki/unit-test-runpath
branch
from
42b7f41 to
89c868a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
-Roption to thechisel3.UnitTestsmain class which mirrors the same option in scalatest's runner. This option allows the user to supply a reduced classpath to be searched for Chisel unit test classes. This allows discovery to be much faster in larger projects with many dependencies, since the classpath contains all dependencies, but the runpath can be limited to discover only test of the current project.Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.