Fix name prefixing from views on rhs of connection #5117
Merged
+37
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
commented
Dec 12, 2025
| case PortBinding(mod) => map2(mod.seedOpt, data.seedOpt)(_ + "_" + _) | ||
| case (_: LitBinding | _: DontCareBinding) => None | ||
| case _ => Some("view_") // TODO implement complex views. | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I recommend hiding whitespace in this diff, it's minimal, mostly tabbing stuff over.
jackkoenig
added
the
Backend Code Generation
Contributor
Author
|
This is sort of a bugfix, but it is likely to have a large impact on generated FIRRTL (and thus Verilog) so I think its worth marking as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Previously views when used on the LHS of a connection operator, views would provide the prefix
view_. Now, at least for 1-1 views, the prefix is derived from the name of the target of the view. This is a common issue when usingFlatIO.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.