Fix boring taps of views of ExtModule ports #5110
Merged
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
commented
Dec 6, 2025
Comment on lines
-196
to
-201
| private[chisel3] def secretConnection(left: Data, _right: Data)(implicit si: SourceInfo): Unit = { | ||
| val (right: Data, _) = chisel3.experimental.dataview | ||
| .reifyIdentityView(_right) | ||
| .getOrElse( | ||
| throwException(s"BoringUtils currently only support identity views, ${_right} has multiple targets.") | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
It felt weird to me that this check was in RawModule, the reason being this is like the final function called by BoringUtils. IMO it's better to do this earlier. All calls to secretConnection in the the method where I moved the reification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach was to move reification (which happened late) to happen earlier. Doing it earlier also makes sense for dealing with non 1-1 views which is definitely possible but will require larger changes so still punting on that (there is a test that it doesn't work that already exists immediately after the test I added).
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
This is a common issue when using
FlatIOwithExtModules.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.