Skip to content

Conversation

@jackkoenig
Copy link
Contributor

Assuming associate supports aggregates, then we should also support non 1-1 views, but it's more complicated to implement so I figured I'd get this out while I ponder how best to handle that. The solution also has implications for how other internal APIs should handle views--I really didn't do a great job on the internal utilities so I'm thinking about that.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Bugfix

Desired Merge Strategy

  • Squash

Release Notes

Also give a useful error message for non-simple views.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Also give a useful error message for non-simple views.
@jackkoenig jackkoenig requested a review from seldridge December 3, 2025 00:19
@jackkoenig jackkoenig added the Bugfix Fixes a bug, will be included in release notes label Dec 3, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you also include a test that this works with FlatIO? (I think it should work now?)

@jackkoenig jackkoenig enabled auto-merge (squash) December 3, 2025 04:10
@jackkoenig jackkoenig merged commit 5e0ae3f into main Dec 3, 2025
17 checks passed
@jackkoenig jackkoenig deleted the jackkoenig/domains-and-views branch December 3, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Fixes a bug, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants