[core] Deprecate ExtModule, Params in experimental #5101
Merged
+29
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate all
Params andExtModuleinside experimental as this ismoving into chisel3 proper in Chisel 8. This is insanely difficult to do
with
case classes, but I think we can just deprecate these as so and theresult is that all
case classmethods are deprecated and we can justmake all these
case classes normalclasses in Chisel 8.Release Notes
Deprecate experimental ExtModule and Params. Also, deprecate the
case classvariants of the Params. These will be made classes in Chisel 8.