Skip to content

Conversation

@adkian-sifive
Copy link
Contributor

BundleSpec is moved from src/test/scala-2 to src/test/scala and now runs with both Scala2 and Scala3. It didn't require any changes save for handling string representation differences between Scala 2 and 3

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Enable CI testing in Scala 3 starting with BundleSpec

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Oct 8, 2025
Comment on lines +199 to 202
(msg should include).regex("Called litValue on aggregate MyBundle*")
msg should include(
"(a=UInt<8>(8), b=Bool(true), c=UInt<4>(DontCare)) contains DontCare"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is matching two things and needs to use a regular expression, FileCheck would be better.

@adkian-sifive adkian-sifive merged commit dd5ca2a into main Oct 8, 2025
16 checks passed
@adkian-sifive adkian-sifive deleted the adkian-sifive/scala3-bundlespec branch October 8, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants