Skip to content

Conversation

@adkian-sifive
Copy link
Contributor

  • Add support for ignoreSeq
  • Move BundlePhase to run after PickleQuotes

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

BundlePhase now runs after PickleQuotes to sidestep Scala 3 compiler bug scala/scala3#23793

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

- Add support for ignoreSeq
- Move BundlePhase to run after PickleQuotes
@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Oct 2, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. I don't have a real grasp of the bundle plugin, though.

@adkian-sifive adkian-sifive merged commit 8a3b6ae into main Oct 6, 2025
19 checks passed
@adkian-sifive adkian-sifive deleted the scala3-bundlephase-updates branch October 6, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants