Skip to content

Conversation

@jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Sep 30, 2025

Suppress MurmurHash3.productHash deprecation until we can also bump Scala 3 to include the replacement API.
It's also not a problem at all, see comment in code.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src? (TODO once 7.2.0 is released)
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Dependency update

Desired Merge Strategy

  • Squash

Release Notes

Note: Scala 2.13.17 has a new warning for inferred structural types as a Scala 3 compatibility issue. This warning applies to the common val io = IO(new Bundle { ... }) pattern in Chisel. It is not actually a problem because Chisel uses Programmatic Structural Types in Scala 3. You can suppress this warning in your build by adding-Wconf:msg=will no longer have a structural type:s to your scalacOptions. See configurable warnings for more details on -Wconf.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@jackkoenig jackkoenig added the Dependency Update Updates a dependency, will be included in release notes label Sep 30, 2025
Suppress MurmurHash3.productHash deprecation until we can also bump
Scala 3 to include the replacement API.
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. It's cool that we're even ahead of the formal 2.13.17 release.

@jackkoenig
Copy link
Contributor Author

See release notes, there's a potential problem for all of our users with a new warning, we might just have to tell everyone to suppress it. I have reached out to the Scala developers about it.

@jackkoenig jackkoenig enabled auto-merge (squash) October 1, 2025 05:02
@jackkoenig jackkoenig merged commit 019c219 into main Oct 1, 2025
16 checks passed
@jackkoenig jackkoenig deleted the scala-2.13.17 branch October 1, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependency Update Updates a dependency, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants