[chiselsim] Drop Temporal layers for Verilator Cli #5024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the CLI Simulator options, set the default explicitly, as opposed to relying on the default simulator in the `HasSimulator` class. This will avoid possible mistakes where this could be changed outside of the mechanisms that are visible to the CLI Simulator. This will also just be more clear. Signed-off-by: Schuyler Eldridge <[email protected]>
Modify the way that `CliOption`s are specified to include the ability to set _default_ behavior when that option is _not_ specified. This fixes a hole in this API where there was no way to modify the settings unless an option was specified on the command line. This was particularly problematic for thiings like the `-Dsimulator` argument which would default to Verilator. Due to the addition of temporal layers, we want to disable these for Verilator. However, we can only do that if the user specified a `-Dsimulator=verilator` argument and not in the unspecified case. This provides an API to make this change to the `Cli.Simulator` possible. Signed-off-by: Schuyler Eldridge <[email protected]>
When running Verilator via the provided `Cli.Simulator` trait, disbale all `Temporal` layers that may exist. This is done because these layers are supposed to guard against temporal properties which are not supported in Verilator. This default-disabled behavior is intentionally only changes for the `Cli.Simulator` as users should use more the standard ChiselSim settings to disable the layers they want to disable. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
added
Feature
jackkoenig
reviewed
Sep 18, 2025
jackkoenig
reviewed
Sep 18, 2025
jackkoenig
approved these changes
Sep 18, 2025
Contributor
jackkoenig
left a comment
jackkoenig
left a comment
There was a problem hiding this comment.
LGTM, I need to get binary compatibility checking working again just to make doing this right easier.
jackkoenig
reviewed
Sep 18, 2025
seldridge
deleted the
dev/seldridge/chiselsim-disable-temporal-layers-in-cli-verilator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable Temporal layers (either internal or those that use the
HasTemporalInlineLayertrait) when use ChiselSim with Verilator via theCli.Simulatortrait.This required adding a number of additional functions to the
CliOptionclassthat can be used to control what happens when an option is not set. This was
a big hole in this API as it created a discontinuity between arguments like
-Dsimulator=verilatorwhich would run settings modification functions and theabsence of any simulator being specified which would not run any settings
modifications. If the settings modifications were non-identity, then this was
incongruous.
Closes #5023.
Release Notes
Disable Temporal layers (either internal or those that use the
HasTemporalInlineLayertrait) when use ChiselSim with Verilator via theCli.Simulatortrait.