[chiselsim] Allow overriding CLI options #5023
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new methodcalled `overrideOption` which behaves like `addOption`, excpet it is requiring that you are overriding an existing option. This is intended to be used internally to allow for us to do some more complicated overrides of the simulator options. Signed-off-by: Schuyler Eldridge <[email protected]>
jackkoenig
reviewed
Sep 17, 2025
| s"unable to override existing option with name '${option.name}' because this option was not previously defined" | ||
| ) | ||
|
|
||
| options += option.name -> option |
Contributor
There was a problem hiding this comment.
Suggested change
| options += option.name -> option | |
| options(option.name) = option |
I think using the setter makes the intent here more obvious (even though you have already done the check).
jackkoenig
reviewed
Sep 17, 2025
Contributor
jackkoenig
left a comment
jackkoenig
left a comment
There was a problem hiding this comment.
This could use a test
seldridge
deleted the
dev/seldridge/chiselsim-allow-overriding-a-cli-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new methodcalled
overrideOptionwhich behaves likeaddOption,excpet it is requiring that you are overriding an existing option. This
is intended to be used internally to allow for us to do some more
complicated overrides of the simulator options.
Release Notes
Add
overrideOptionmethod to allow ChiselSim CLIs to override an existingoption. This is primarily used for changing the "modifications" of the
Simulatorupstream option.