[core] Add LayerControl.Disable #5019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `LayerControl.Disable` type which allows for a variadic list of layers to be disabled. This complements the other existing controls, `Enable(...)`, `EnableAll`, and `DisableAll`, particularly with the addition of the new `Temporal` layers which you often want to only disable for Verilator. This makes it easier to disable just those layers, as opposed to having to remember all the layers that need to be enabled (and having your test silently not enable new layers if they are created). Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
LayerControl.Disabletype which allows for a variadic list oflayers to be disabled. This complements the other existing controls,
Enable(...),EnableAll, andDisableAll, particularly with theaddition of the new
Temporallayers which you often want to only disablefor Verilator. This makes it easier to disable just those layers, as
opposed to having to remember all the layers that need to be enabled (and
having your test silently not enable new layers if they are created).
Release Notes
Add
LayerControl.Disableto disable a variadic list of layers at simulatorcompilation time.