[core] Add Temporal inline layer, trait #5018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `Temporal` inline layers that are nested under each of the builtin Assert, Assume, and Cover layers. These layers exist because we have observed situations where assertions which _should_ be legal in all designs are unsupported by specific tools, though they are legal properties by the SystemVerilog spec. E.g., `s_eventually` is entirely unsupported by Verilator and has only limited support in VCS. The motivation for this PR is to have a location where we can put these assertions and guard them off with tools that do not support them. Because this is expected to be problematic for all of the existing builtin layers, this is added to each of Assert, Assume, and Cover. Additionally, as users have user-defined layers, the pattern of creating this `Temporal` layer is factored into a trait, `HasTemporalInlineLayer` so that it can be reused by others. Signed-off-by: Schuyler Eldridge <[email protected]>
Member
Author
|
The name could be improved. Bikeshed comments are welcome, too. |
rwy7
approved these changes
Sep 9, 2025
Add the temporal layers to Chisel's default layers. This is necessary to avoid these layers needing to be manually included by users. It's annoying that they're enabled, but because they are inline, it doesn't create unnecessary files. Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
Temporalinline layers that are nested under each of thebuiltin Assert, Assume, and Cover layers. These layers exist because we
have observed situations where assertions which should be legal in all
designs are unsupported by specific tools, though they are legal
properties by the SystemVerilog spec.
E.g.,
s_eventuallyis entirely unsupported by Verilator and has onlylimited support in VCS. The motivation for this PR is to have a location
where we can put these assertions and guard them off with tools that do
not support them.
Because this is expected to be problematic for all of the existing builtin
layers, this is added to each of Assert, Assume, and Cover. Additionally,
as users have user-defined layers, the pattern of creating this
Temporallayer is factored into a trait,
HasTemporalInlineLayerso that it can bereused by others.
Release Notes
Temporallayer under each of the builtinAssert,Assume, andCoverlayers. This is intended to be used to guard complex or unsupportedproperties due to spotty simulator support.
HasTemporalInlineLayertrait to allow users to easily add a recognizableTemporalchild layer to their user-defined layers.