Support emitting variadic cat #4992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Woohoo! Glad it was easy 😁 🤞 . Can't wait to never see hi_hi_lo_lo_hi_lo_hi_hi in FIRRTL source again! 😉 |
jackkoenig
force-pushed
the
jackkoenig/variadic-cat
branch
from
efff5f9 to
d4b30b0
Compare
To avoid emitting nodes simply to cast SInts to UInts, improve the internal IR with PrimExpr which are primitive expressions.
jackkoenig
force-pushed
the
jackkoenig/variadic-cat
branch
from
d4b30b0 to
35486ce
Compare
jackkoenig
added
the
Backend Code Generation
Contributor
Author
|
Ready for review at your leisure @seldridge. I think we separately also need to bump the emitted Firrtl Version before 7.0 release. I'm running an internal smoke test to make sure there are no surprises but I'm not worried. |
seldridge
approved these changes
Aug 18, 2025
Comment on lines
-57
to
+56
| chirrtl should include("node lo_lo = cat(in[6], in[7])") | ||
| chirrtl should include("node lo_hi = cat(in[4], in[5])") | ||
| chirrtl should include("node hi_lo = cat(in[2], in[3])") | ||
| chirrtl should include("node hi_hi = cat(in[0], in[1])") | ||
| chirrtl should include("cat(in[0], in[1], in[2], in[3], in[4], in[5], in[6], in[7])") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version was surprisingly easy, but ended up being a little more complicated because I added support to Chisel's internal IR for complex expressions instead of every expression also being a Statement.
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
This should not be visible to most users unless they inspect emitted
.fir. It reduces memory use, improves performance, and reduces the size of emitted.fira little bit, ~2-5% depending on the design.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.