[core] Switch to FIRRTL 6.0.0 inline layer ABI #4982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The forthcoming FIRRTL 6.0.0 makes some changes to the ABI for inline layers [[1]]. Specifically, the module name was dropped and the delimiter _after_ "layer" was changed from '_' to '$'. E.g., what was previously: ``` layer_Foo$A ``` Is now: ``` layer$A ``` Propagate this change into Chisel by updating the way that inline layers self-report their ABI. This is needed to keep Chisel compatible with CIRCT 1.126.0. [1]: chipsalliance/firrtl-spec@b88817b Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/new-inline-layer-abi
branch
from
586a287 to
6f06a77
Compare
Member
Author
|
I amended (without editing) the last commit in this PR in order to refresh CI. Now that a nightly is available, this should fix the nightly failure observed here: https://github.com/chipsalliance/chisel/actions/runs/16369009004 |
rwy7
approved these changes
Jul 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
The forthcoming FIRRTL 6.0.0 makes some changes to the ABI for inline layers [[1]]. Specifically, the module name was dropped and the delimiter _after_ "layer" was changed from '_' to '$'. E.g., what was previously: ``` layer_Foo$A ``` Is now: ``` layer$A ``` Propagate this change into Chisel by updating the way that inline layers self-report their ABI. This is needed to keep Chisel compatible with CIRCT 1.126.0. [1]: chipsalliance/firrtl-spec@b88817b Signed-off-by: Schuyler Eldridge <[email protected]>
chiselbot
pushed a commit
that referenced
this pull request
Jul 25, 2025
The forthcoming FIRRTL 6.0.0 makes some changes to the ABI for inline layers [[1]]. Specifically, the module name was dropped and the delimiter _after_ "layer" was changed from '_' to '$'. E.g., what was previously: ``` layer_Foo$A ``` Is now: ``` layer$A ``` Propagate this change into Chisel by updating the way that inline layers self-report their ABI. This is needed to keep Chisel compatible with CIRCT 1.126.0. [1]: chipsalliance/firrtl-spec@b88817b Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forthcoming FIRRTL 6.0.0 makes some changes to the ABI for inline layers [1]. Specifically, the module name was dropped and the delimiter after "layer" was changed from '_' to '$'. E.g., what was previously:
Is now:
Propagate this change into Chisel by updating the way that inline layers self-report their ABI. This is needed to keep Chisel compatible with CIRCT 1.126.0.
Note: this needs a nightly which has the CIRCT changes here [2] and this is currently not available.