[panama] Remove OMMap, dropped in CIRCT 1.126.0 #4978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think this can be made directly against |
Remove dropped OM Map features that will appear in CIRCT 1.126.0. This was removed in this patch [[1]]. [1]: llvm/circt@2beb8e7 Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/nightly-fix-ommap-removal
branch
from
a7e18cf to
0622e7c
Compare
jackkoenig
approved these changes
Jul 15, 2025
Contributor
jackkoenig
left a comment
jackkoenig
left a comment
There was a problem hiding this comment.
SGTM, I wouldn't call this an API Modification as this code is not published so isn't part of the public API as far as release notes are concerned.
seldridge
added
No Release Notes
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
Remove dropped OM Map features that will appear in CIRCT 1.126.0. This was removed in this patch [[1]]. [1]: llvm/circt@2beb8e7 Signed-off-by: Schuyler Eldridge <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
Remove dropped OM Map features that will appear in CIRCT 1.126.0. This was removed in this patch [[1]]. [1]: llvm/circt@2beb8e7 Signed-off-by: Schuyler Eldridge <[email protected]>
chiselbot
pushed a commit
that referenced
this pull request
Jul 25, 2025
Remove dropped OM Map features that will appear in CIRCT 1.126.0. This was removed in this patch [[1]]. [1]: llvm/circt@2beb8e7 Signed-off-by: Schuyler Eldridge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dropped OM Map features that will appear in CIRCT 1.126.0. This
was removed in this patch [1].