[ChiselSim] Factor reset procedure out of SimulatorAPI and into stimulus #4784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
dev/seldridge/stimulus-ResetProcedure
branch
from
c6ba878 to
3720488
Compare
Copy the reset initialization procedure from the `SimulatorAPI` into `stimulus.ResetProcedure`. This will allow for better reuse of this stimulus and, in a follow-on, will allow for simplification of the `SimulatorAPI`. Signed-off-by: Schuyler Eldridge <[email protected]>
Refactor the `SimulatorAPI` to use the canned `ResetProcedure` stimulus as opposed to hand-rolling it. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/stimulus-ResetProcedure
branch
from
3720488 to
a7effb7
Compare
jackkoenig
reviewed
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor the reset initialization procedure out of
SimulatorAPI.simulateand into a separate, re-usable stimulus.Release Notes
Add
stimulus.ResetProcedurethat encapsulates a simple circuit initialization procedure. This is customizable for non-Modules by specifying a clock and reset.