[simulator] Remove DefaultSimulator #4763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `DefaultSimulator`. This is fully replaced with the `ChiselSim` API and is no longer needed. Notably, `DefaultSimulator` never made it onto an actual release of Chisel so this is safe to just remove. Rewrite EphemeralSimulator in terms of ChiselSim APIs. Migrate tests of DefaultSimulator to tests on ChiselSim or other simulator classes, objects, and methods. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
added
the
No Release Notes
jackkoenig
reviewed
Mar 3, 2025
Comment on lines
+21
to
+28
| private val chiselSim = new ChiselSim {} | ||
|
|
||
| def simulate[T <: RawModule]( | ||
| module: => T, | ||
| layerControl: LayerControl.Type = LayerControl.EnableAll | ||
| )(body: (T) => Unit): Unit = { | ||
| implicit val temporary = HasTestingDirectory.temporary(deleteOnExit = true) | ||
| DefaultSimulator.simulateRaw( | ||
| implicit val temporary: HasTestingDirectory = HasTestingDirectory.temporary(deleteOnExit = true) | ||
| chiselSim.simulateRaw( |
Contributor
There was a problem hiding this comment.
Is the ChiselSim object stateful? I assume you're sharing it between multiple runs for a reason (presumably more performant if it isn't stateful) but just want to check that's intentional.
Member
Author
There was a problem hiding this comment.
No mutability other than that exposed by TestingDirectory's dynamic variable testName which is set from a fixture.
Or: other than that, it is definitely immutable as it is just packaging up SimulatorAPI (just methods) with PeekPokeAPI (methods and classes).
This should be safe.
jackkoenig
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
DefaultSimulator. This is fully replaced with theChiselSimAPI and is no longer needed. Notably,DefaultSimulatornever made it onto an actual release of Chisel so this is safe to just remove.Rewrite EphemeralSimulator in terms of ChiselSim APIs. Migrate tests of DefaultSimulator to tests on ChiselSim or other simulator classes, objects, and methods.
This does not have release notes, but we should delete the release notes about
DefaultSimulatorwhen releasing Chisel 7.