add PopCount atLeast API #2711
Closed
add PopCount atLeast API #2711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
reviewed
Aug 29, 2022
| private def _apply_impl(in: Iterable[Bool])(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): UInt = | ||
| SeqUtils.count(in.toSeq) | ||
|
|
||
| /** a threshold PopCount which has optimization to 0,1,2. |
Contributor
There was a problem hiding this comment.
Suggested change
| /** a threshold PopCount which has optimization to 0,1,2. | |
| /** performs PopCount(x) >= n.U, with optimizations for n=0,1,2 |
aswaterman
reviewed
Aug 29, 2022
| case 0 => true.B | ||
| case 1 => x.orR | ||
| case 2 => two(x)._2 | ||
| case 3 => PopCount(x) >= n.U |
Member
There was a problem hiding this comment.
This should be case _, not case 3. (Otherwise it'll crash for n >= 4. It's a bug in rocket-chip, too)
jackkoenig
reviewed
Aug 29, 2022
| def atLeast(n: Int, x: UInt): Bool = macro SourceInfoTransform.nxArg | ||
|
|
||
| /** @group SourceInfoTransformMacro */ | ||
| def do_atLeast(n: Int, x: UInt)(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): UInt = { |
Contributor
There was a problem hiding this comment.
Suggested change
| def do_atLeast(n: Int, x: UInt)(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): UInt = { | |
| def do_atLeast(n: Int, x: UInt)(implicit sourceInfo: SourceInfo, compileOptions: CompileOptions): Bool = { |
14 tasks
Contributor
|
Merged in #5002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
API Impact
Backend Code Generation Impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Enable auto-merge (squash), clean up the commit message, and label withPlease Merge.Create a merge commit.