Skip to content

Commit de37392

Browse files
authored
Remove Mac mac_unopt builder (flutter#196027)
The standalone builders added in flutter#195868 are passing, remove `bringup: true` and delete the `Mac mac_unopt` builder. The new builds ran on this PR, for example: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_host_release_arm64_licenses/1/overview A few docs linked to mac_unopt.json or used it as an example, point them instead to the `standalone/` configs. Part of flutter#155041 Fixes flutter#186462 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 7846f0a commit de37392

7 files changed

Lines changed: 10 additions & 485 deletions

File tree

‎docs/infra/Security.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ Sanitizer builds:
1919
Tests with assertions enabled:
2020

2121
* [Linux unopt](https://ci.chromium.org/p/flutter/builders/prod/Linux%20Unopt)
22-
* [Mac unopt](https://ci.chromium.org/p/flutter/builders/prod/Linux%20mac_unopt)
22+
* [Mac unopt](https://ci.chromium.org/p/flutter/builders/prod/Mac%20mac_host_debug_unopt_arm64)
2323
* [Windows unopt](https://ci.chromium.org/p/flutter/builders/prod/Windows%20Unopt)

‎engine/src/flutter/.ci.yaml‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -506,56 +506,43 @@ targets:
506506
config_name: mac_clangd
507507
cpu: arm64
508508

509-
- name: Mac mac_unopt
510-
recipe: engine_v2/engine_v2
511-
properties:
512-
config_name: mac_unopt
513-
add_recipes_cq: "true"
514-
timeout: 120
515-
516509
- name: Mac mac_host_debug_arm64_tests
517510
recipe: engine_v2/builder
518-
bringup: true
519511
timeout: 120
520512
properties:
521513
config_name: mac_host_debug_arm64_tests
522514
cpu: arm64
523515

524516
- name: Mac mac_host_profile_arm64_tests
525517
recipe: engine_v2/builder
526-
bringup: true
527518
timeout: 120
528519
properties:
529520
config_name: mac_host_profile_arm64_tests
530521
cpu: arm64
531522

532523
- name: Mac mac_host_release_arm64_tests
533524
recipe: engine_v2/builder
534-
bringup: true
535525
timeout: 120
536526
properties:
537527
config_name: mac_host_release_arm64_tests
538528
cpu: arm64
539529

540530
- name: Mac mac_host_release_arm64_licenses
541531
recipe: engine_v2/builder
542-
bringup: true
543532
timeout: 120
544533
properties:
545534
config_name: mac_host_release_arm64_licenses
546535
cpu: arm64
547536

548537
- name: Mac mac_release_arm64_tests
549538
recipe: engine_v2/builder
550-
bringup: true
551539
timeout: 120
552540
properties:
553541
config_name: mac_release_arm64_tests
554542
cpu: arm64
555543

556544
- name: Mac mac_host_debug_unopt_arm64
557545
recipe: engine_v2/builder
558-
bringup: true
559546
timeout: 120
560547
properties:
561548
add_recipes_cq: "true"
@@ -564,7 +551,6 @@ targets:
564551

565552
- name: Mac mac_ios_debug_unopt_sim_arm64
566553
recipe: engine_v2/builder
567-
bringup: true
568554
timeout: 120
569555
properties:
570556
add_recipes_cq: "true"
@@ -578,7 +564,6 @@ targets:
578564

579565
- name: Mac mac_ios_debug_unopt_sim_arm64_extension_safe
580566
recipe: engine_v2/builder
581-
bringup: true
582567
timeout: 120
583568
properties:
584569
config_name: mac_ios_debug_unopt_sim_arm64_extension_safe

0 commit comments

Comments
 (0)