Skip to content

docs(websocket): improve example for online IDE #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chimurai merged 1 commit into from
Apr 20, 2024
Merged

docs(websocket): improve example for online IDE #990

chimurai merged 1 commit into from
Apr 20, 2024

Conversation

@chimurai
Copy link
Owner

@chimurai chimurai commented Apr 20, 2024

  • remove hardcoded ws://localhost
  • use URL of online IDE when applicable

@chimurai chimurai enabled auto-merge (squash) April 20, 2024 12:22
@chimurai chimurai merged commit 471349f into master Apr 20, 2024
@chimurai chimurai deleted the improve-ws-example branch April 20, 2024 12:23
@coveralls
Copy link

coveralls commented Apr 20, 2024

Coverage Status

coverage: 97.644%. remained the same
when pulling df88d56 on improve-ws-example
into e644a22 on master.

@leoo1992 leoo1992 mentioned this pull request Sep 25, 2024
Merged
@AntonUrb AntonUrb mentioned this pull request Nov 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chimurai @coveralls