refactor: use node http base types [BREAKING CHANGE]#730
Merged
Conversation
5 tasks
chimurai
force-pushed
the
node-http-base-types
branch
11 times, most recently
from
e27989b to
15a7e60
Compare
chimurai
force-pushed
the
node-http-base-types
branch
from
15a7e60 to
f01e972
Compare
chimurai
changed the title
chimurai
force-pushed
the
node-http-base-types
branch
from
f01e972 to
03eef2c
Compare
2 tasks
This was referenced Mar 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
See #719
Thanks @devanshj @cdaringe for doing initial work (#478, #721, #723) and help to nudge the types into the correct direction!
How has this been tested?
Unit tests
Types of changes
Checklist: