Expose HTTP Proxy middleware, so it can be used outside express#687
Closed
Legoless wants to merge 3 commits intochimurai:masterfrom
Closed
Expose HTTP Proxy middleware, so it can be used outside express#687Legoless wants to merge 3 commits intochimurai:masterfrom
Legoless wants to merge 3 commits intochimurai:masterfrom
Conversation
Closed
|
#721 does this properly. this PR should be closed. this is an abuse of |
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to make it possible to use the middleware outside Express. For example we integrated the library with NestJS using
NestMiddlewareand Fastify.Description
This requires the change of
middlewaretype toany(since there are no internal defined types that can be used instead for now). Additional methodcreateProxyis added, which returnsHttpProxyMiddleware, thus exposing themiddlewaredirectly, giving a bit more flexibility.Motivation and Context
The only exposed method returns an Express
RequestHandlerobject, which TypeScript does not recognize as callable in NestJS environment. Changing this toanyallows it to be called from TypeScript.How has this been tested?
Has been tested by deploying to internal servers and thoroughly connected with NestJS.
Types of changes
Checklist:
The change is backward compatible and does not break any code.