Skip to content

Preventing the fail of the 'ETIMEDOUT' code in 500 'Internal server error'#480

Merged
chimurai merged 2 commits intochimurai:masterfrom
aremishevsky:master
Jan 12, 2021
Merged

Preventing the fail of the 'ETIMEDOUT' code in 500 'Internal server error'#480
chimurai merged 2 commits intochimurai:masterfrom
aremishevsky:master

Conversation

@aremishevsky
Copy link
Copy Markdown
Contributor

Currently ETIMEDOUT code is handled by the defaultErrorHandler as a [500] Internal Server Error.
It should be handled as the regular ECONNRESET || ENOTFOUND || ECONNREFUSED || ETIMEDOUT codes.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 27, 2020

Coverage Status

Coverage remained the same at 88.301% when pulling dbca54f on aremishevsky:master into f77121f on chimurai:master.

@aremishevsky
Copy link
Copy Markdown
Contributor Author

@chimurai could you please review this PR?

@aremishevsky
Copy link
Copy Markdown
Contributor Author

Can someone review and merge this PR?

@chimurai
Copy link
Copy Markdown
Owner

@chimurai
Copy link
Copy Markdown
Owner

Oops, missed that. 🙈

@chimurai chimurai merged commit 7ae82e8 into chimurai:master Jan 12, 2021
@chimurai
Copy link
Copy Markdown
Owner

Thanks for this PR!

@aremishevsky
Copy link
Copy Markdown
Contributor Author

Could you please let me know when the new version would be available on the npm?

sarumont pushed a commit to sarumont/http-proxy-middleware that referenced this pull request Jan 12, 2021
@chimurai
Copy link
Copy Markdown
Owner

Published in v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants