Coverage decreased (-0.2%) to 88.149% when pulling 67a9e5d on TrySound:avoid-lodash into 7ae82e8 on chimurai:master.

This pull request introduces 4 alerts when merging 9b81199 into 5384dcf - view on LGTM.com

new alerts:

• 2 for Unused loop iteration variable
• 2 for Unused variable, import, function or class

Friendly ping @chimurai

Hi @TrySound

Thanks for the PR.
Some effort was already started in this thread. #428

Noticed some skipped tests. What is the reason for that?

I wish I remember. Probably they were not stable locally even before my changes.

I plan to continue the effort after merging this PR.

Congratulations 🎉. DeepCode analyzed your code in 5.507 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Retry DeepCode

Hi @@chimurai is this good to go?

Hi @TrySound,

Thanks for the reminder.

Question: Why were tests changed with extra return statement:
return expect(rewriter(rewriteFn)).resolves.toBe('/123/456');

Think it looks good. (Want to do some additional manual testing)

Some tests errored with unhandled rejection when I debugged code. Promise should be returned there. Nothing need to return explicitly with async await btw.

Friendly ping @chimurai

Friendly ping from 2021, is this still in work ?

Thanks!