DeepCode's analysis on #478d9b found:

• ❌ 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

Coverage remained the same at 87.778% when pulling 478d9bb on rsethc:master into 483911a on chimurai:master.

Nice. Looks good.

The following needs to be in place before this PR can be accepted:

• Updated documentation README.md
• unit test(s) for pathRewriter
• unit test types.spec.ts (testing for the async syntax)

You can have a look at:
Similar PR, but for async router: https://github.com/chimurai/http-proxy-middleware/pull/379/files

Unit tests for path rewriter:
https://github.com/chimurai/http-proxy-middleware/blob/master/test/unit/path-rewriter.spec.ts

Types test:
https://github.com/chimurai/http-proxy-middleware/blob/master/test/types.spec.ts
example of async router: https://github.com/chimurai/http-proxy-middleware/blob/master/test/types.spec.ts#L74

Alright, I'll take a look at solving these requirements. Thanks

I think this is ready to have another look. One change I made by accident affected the yarn.lock file, let me know if it's preferable to add a commit that undoes that.

Yes, please undo the changes to yarn.lock

I'll checkout the PR to do some additional testing.

Thanks!

Published a new beta version

You can install it with:
npm install http-proxy-middleware@beta or npm install [email protected]

Let me know if everything still works. I'll publish a final shortly after confirmation.

Thanks, I'll try out this version and let you know if anything goes wrong.

The "[email protected]" seems to work as expected in what I'm working on.

published final version: [email protected]