fix(log): Handle case when error code is missing#303
Merged
chimurai merged 2 commits intochimurai:masterfrom Nov 25, 2018
sorin-davidoi:patch-1
Merged
fix(log): Handle case when error code is missing#303chimurai merged 2 commits intochimurai:masterfrom sorin-davidoi:patch-1
chimurai merged 2 commits intochimurai:masterfrom
sorin-davidoi:patch-1
Conversation
# Before ``` HPM] Error occurred while trying to proxy request <redacted> from <redacted> to <redacted> (undefined) (https://nodejs.org/api/errors.html#errors_common_system_errors) ``` # After ``` [HPM] Error occurred while trying to proxy request <redacted> from <redacted> to <redacted> (Error: Hostname/IP doesn't match certificate's altnames: "Host: <redacted>. is not in the cert's altnames: DNS:<redacted>, DNS:<redacted>") (https://nodejs.org/api/errors.html#errors_common_system_errors) ```
Owner
|
Thanks @sorin-davidoi . Can you update the PR description on how to reproduce this issue? |
|
See also #263 for a variant ( I haven't tested a minimal example, but I suspect that another way to reproduce this would be to copy the basic https recipe and remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce supply a custom certificate with altnames (e.g.
localhost:5000) that does not includelocalhost:<port>and start server onlocalhost:<port>(e.g.localhost:3000).Before
After