Walkthrough

Added Node.js agent imports and a new E2E test that verifies the router dynamically assigns different HTTPS agents per request; the test spies on each agent's createConnection, routes requests to separate targets based on URL, and asserts each agent was used exactly once.

Changes

Dynamic Agent Selection E2E Test

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant ProxyRouter
  participant HttpsAgentA
  participant HttpsAgentB
  participant TargetA
  participant TargetB

  Client->>ProxyRouter: GET /api/a
  ProxyRouter->>HttpsAgentA: set options.agent = agentA
  ProxyRouter->>TargetA: proxy request (agentA)
  HttpsAgentA->>TargetA: createConnection()
  TargetA-->>Client: response A

  Client->>ProxyRouter: GET /api/b
  ProxyRouter->>HttpsAgentB: set options.agent = agentB
  ProxyRouter->>TargetB: proxy request (agentB)
  HttpsAgentB->>TargetB: createConnection()
  TargetB-->>Client: response B

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chimurai/http-proxy-middleware#1244: The E2E test uses per-request options mutation (setting options.agent in router callbacks) that is implemented by this PR.

Poem

🐰 A rabbit hops through agent gates,
Each request picks its destined fate,
Two agents wait, connections spy,
Targets answer as requests fly,
Hooray — per-request paths verified!

❌ Failed checks (1 warning)

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• X
• Mastodon
• Reddit
• LinkedIn