Skip to content

chore(package.json): remove patch-package#1217

Merged
chimurai merged 1 commit intomasterfrom
dev-deps-remove-patch-package
Apr 29, 2026
Merged

chore(package.json): remove patch-package#1217
chimurai merged 1 commit intomasterfrom
dev-deps-remove-patch-package

Conversation

@chimurai
Copy link
Copy Markdown
Owner

@chimurai chimurai commented Apr 29, 2026 •
edited by coderabbitai Bot
Loading

no need to patch punycode in uri-js anymore since node v22.14.0

eslint/eslint#19369 (comment)

Summary by CodeRabbit

  • Chores
    • Removed a development dependency and simplified the corresponding build configuration.
    • Updated module import specifications to improve compatibility.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026 •
edited
Loading

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The pull request removes the patch-package dependency and its integration from the build process. The prepare lifecycle script is simplified to only run husky, and the associated patch file for uri-js imports is no longer being applied.

Changes

Cohort / File(s) Summary
Build Configuration
package.json		 Removed patch-package from devDependencies and resolutions. Updated prepare script to run only husky instead of husky && patch-package.
Unused Patch
patches/uri-js+4.4.1.patch		 Patch file defining punycode import changes for uri-js distribution files. No longer applied due to patch-package removal.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A patch-package goes away,
Husky stands alone today,
Simpler scripts, lighter load,
Cleaner paths down build's road! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removal of patch-package from package.json. It is concise, specific, and clearly conveys the primary modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-deps-remove-patch-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 29, 2026 

npm i https://pkg.pr.new/http-proxy-middleware@1217

commit: 7efa77b

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 29, 2026

Coverage Status

coverage: 94.07%. remained the same — dev-deps-remove-patch-package into master

@chimurai chimurai merged commit 2c6768b into master Apr 29, 2026
23 of 24 checks passed
@chimurai chimurai deleted the dev-deps-remove-patch-package branch April 29, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chimurai @coveralls