test/test-utils.ts (1)

24-33: Use vi.spyOn() for emit to maintain consistency and preserve EventEmitter return behavior.

Line 29 replaces emit outright with vi.fn(), unlike the other methods on lines 31–33 which use vi.spyOn(). This inconsistency also drops the method's boolean return value. While the current test doesn't depend on this, use vi.spyOn(clientRequest, 'emit').mockImplementation(() => true) to keep the pattern consistent and avoid masking potential event-flow issues.

Suggested patch

 export function createMockClientRequest(
   ...args: ConstructorParameters<typeof ClientRequest>
 ): ClientRequest {
   const clientRequest = new ClientRequest(...args);
 
-  clientRequest.emit = vi.fn();
+  vi.spyOn(clientRequest, 'emit').mockImplementation(() => true);
 
   vi.spyOn(clientRequest, 'setHeader');
   vi.spyOn(clientRequest, 'write');
   vi.spyOn(clientRequest, 'destroy');
 
   return clientRequest;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/test-utils.ts` around lines 24 - 33, The test helper
createMockClientRequest currently replaces clientRequest.emit with vi.fn(),
breaking consistency and losing the EventEmitter boolean return; change that to
use vi.spyOn(clientRequest, 'emit').mockImplementation(() => true) instead of
direct assignment, keeping the other spies (setHeader, write, destroy) as-is so
emit preserves its return value and follows the same spy pattern.

test/e2e/router.spec.ts (1)

123-139: Test name may be stale after refactoring.

The test is named "missing a ':' in protocol will cause it to use https" but the implementation now uses target.protocol which includes the colon (e.g., "https:"). The test still passes because HTTPS is used, but the name no longer reflects what's being tested.

Consider renaming to better reflect the current behavior:

📝 Proposed name update

-    it('missing a ":" in protocol will cause it to use https', async () => {
+    it('should work with URL-derived protocol', async () => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/router.spec.ts` around lines 123 - 139, Rename the test case whose
title is "missing a ':' in protocol will cause it to use https" to accurately
reflect that the router callback returns target.protocol (which includes the
colon, e.g., "https:"), for example "router returning protocol with colon uses
https" or similar; update the it(...) description where createProxyMiddleware is
invoked and the router callback returns { host: target.hostname, port:
target.port, protocol: target.protocol } so the test name matches the actual
behavior being asserted.

test/unit/fix-request-body.spec.ts (1)

160-176: proxyResponse is unused in this test.

The proxyResponse mock is created on line 168 but is never passed to fixRequestBody(). The assertion on line 173 (expect(proxyResponse.end).toHaveBeenCalledTimes(0)) will always pass trivially since proxyResponse is not involved in the function under test.

Consider removing this dead code or clarifying the test intent:

♻️ Proposed fix to remove unused mock

   it('should not fixRequestBody() when there bodyParser fails', () => {
     const proxyRequest = fakeProxyRequest();
     const request = {
       get readableLength() {
         return 4444; // simulate bodyParser failure
       },
     } as BodyParserLikeRequest;

-    const proxyResponse = createMockResponse();
     proxyRequest.setHeader('content-type', 'application/x-www-form-urlencoded');

     fixRequestBody(proxyRequest, request);

-    expect(proxyResponse.end).toHaveBeenCalledTimes(0);
     expect(proxyRequest.write).toHaveBeenCalledTimes(0);
     expect(proxyRequest.destroy).toHaveBeenCalledTimes(0);
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/unit/fix-request-body.spec.ts` around lines 160 - 176, The test creates
an unused proxyResponse mock and asserts on it even though
fixRequestBody(proxyRequest, request) never receives it; remove the dead
proxyResponse variable and its assertion (expect(proxyResponse.end)...), or if
you intended to assert behavior on the response, pass that mock into
fixRequestBody and update the function call accordingly. Locate the
proxyResponse declaration in the test and either delete its creation and the
expect(proxyResponse.end).toHaveBeenCalledTimes(0) line, or change the call to
fixRequestBody(proxyRequest, request, proxyResponse) and adjust fixRequestBody
to accept and use that third parameter.