Skip to content

chore(examples): add ts-check#1192

Merged
chimurai merged 1 commit intomasterfrom
ts-check-examples
Apr 5, 2026
Merged

chore(examples): add ts-check#1192
chimurai merged 1 commit intomasterfrom
ts-check-examples

Conversation

@chimurai
Copy link
Copy Markdown
Owner

@chimurai chimurai commented Apr 5, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores
    • Enhanced TypeScript type-checking support for example configurations across multiple modules.
    • Updated spell-check configuration to remove unnecessary custom word entries.
    • Minor configuration adjustments for consistency.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 5, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e57fb871-53f4-40e6-989f-14e606f93a66

📥 Commits

Reviewing files that changed from the base of the PR and between 42fb02e and 77294ce.

📒 Files selected for processing (7)
  • cspell.json
  • examples/browser-sync/index.js
  • examples/connect/index.js
  • examples/express/index.js
  • examples/http-server/index.js
  • examples/response-interceptor/index.js
  • examples/websocket/index.js
💤 Files with no reviewable changes (1)
  • cspell.json
📝 Walkthrough

Walkthrough

Configuration and example files are updated with TypeScript type-checking directives and cleaned of DeepCode-specific annotations. The spell-checker configuration removes a custom word entry. No runtime behavior or control flow changes.

Changes

Cohort / File(s) Summary
Spell-Check Configuration
cspell.json		 Removed deepcode from the custom words list, disabling spell-checker exception for that term.
Type-Check Annotations
examples/connect/index.js, examples/express/index.js, examples/http-server/index.js, examples/websocket/index.js		 Added // @ts-check`` directives to enable TypeScript type-checking in JavaScript files.
DeepCode Cleanup & Type-Check
examples/response-interceptor/index.js		 Added // @ts-check`` directive and removed two DeepCode-specific lint directives.
Configuration Reordering
examples/browser-sync/index.js		 Reordered browserSync init configuration object properties without altering functionality.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The types now checked with careful care,
DeepCode whispers fade in air,
A spell-word goes, directives stay,
Clean code hops forth into the day! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(examples): add ts-check' accurately summarizes the primary change: adding TypeScript type-checking directives to example files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ts-check-examples

Comment @coderabbitai help to get the list of available commands and usage tips.

@chimurai chimurai force-pushed the ts-check-examples branch from bd5b234 to 77294ce Compare April 5, 2026 13:11
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 5, 2026 •
edited
Loading 

npm i https://pkg.pr.new/http-proxy-middleware@1192

commit: 77294ce

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 5, 2026 •
edited
Loading

Coverage Status

coverage: 94.012%. remained the same
when pulling 77294ce on ts-check-examples
into 42fb02e on master.

@chimurai chimurai merged commit 87107bf into master Apr 5, 2026
21 checks passed
@chimurai chimurai deleted the ts-check-examples branch April 5, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chimurai @coveralls