Skip to content

refactor(is-plain-object): replace with is-plain-obj#1191

Merged
chimurai merged 1 commit intomasterfrom
is-plain-obj
Apr 5, 2026
Merged

refactor(is-plain-object): replace with is-plain-obj#1191
chimurai merged 1 commit intomasterfrom
is-plain-obj

Conversation

@chimurai
Copy link
Copy Markdown
Owner

@chimurai chimurai commented Apr 5, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores
    • Replaced an internal plain-object helper dependency with an alternative implementation to streamline checks.
    • Removed two local package patches that previously adjusted a low-level URL/punycode import, reverting those modules to their standard upstream behavior.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 5, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0ea28dba-2665-4c6e-8110-c23582843249

📥 Commits

Reviewing files that changed from the base of the PR and between 97da5f3 and 972766c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (5)
  • package.json
  • patches/tr46+0.0.3.patch
  • patches/whatwg-url+5.0.0.patch
  • src/path-rewriter.ts
  • src/router.ts
💤 Files with no reviewable changes (2)
  • patches/whatwg-url+5.0.0.patch
  • patches/tr46+0.0.3.patch
✅ Files skipped from review due to trivial changes (3)
  • src/router.ts
  • package.json
  • src/path-rewriter.ts
📝 Walkthrough

Walkthrough

The diff replaces the is-plain-object dependency with is-plain-obj, updates two TypeScript imports to use the new default import shape, and removes two patch hunks that altered punycode require paths in vendored tr46 and whatwg-url files.

Changes

Cohort / File(s) Summary
Dependency Update
package.json		 Replaced dependency is-plain-object (^5.0.0) with is-plain-obj (^4.1.0).
Import Refactoring
src/path-rewriter.ts, src/router.ts		 Swapped named import { isPlainObject } from is-plain-object for default import isPlainObject from is-plain-obj; runtime checks and logic unchanged.
Removed Patches
patches/tr46+0.0.3.patch, patches/whatwg-url+5.0.0.patch		 Removed patch hunks that changed internal require("punycode") to require("punycode/") in vendored tr46 and whatwg-url files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop, a swap without a fuss,

New name in package, old import's been dust,
Objects still plain, the checks still sing,
Patches rolled back—everything's spring.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing the is-plain-object dependency with is-plain-obj across package.json and source files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch is-plain-obj

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 5, 2026 •
edited
Loading

Coverage Status

coverage: 94.012%. remained the same
when pulling 972766c on is-plain-obj
into 3e7d6df on master.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 5, 2026 

npm i https://pkg.pr.new/http-proxy-middleware@1191

commit: 972766c

@chimurai chimurai merged commit 42fb02e into master Apr 5, 2026
21 checks passed
@chimurai chimurai deleted the is-plain-obj branch April 5, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chimurai @coveralls