refactor(#1136): replace `http-proxy` w/ `httpxy` by SukkaW · Pull Request #1160 · chimurai/http-proxy-middleware

SukkaW · 2026-02-07T20:42:46Z

Description

Another attempt to fix #1136.

Unlike #1159, instead of replacing http-proxy w/ http-proxy-3, the PR chooses httpxy, because:

httpxy is way more popular and more battle-tested:
- http-proxy-3 only has about 45K weekly downloads right now
- while httpxy has about 1.1M weekly downloads right now
httpxy has a smaller installation size, hence a smaller footprint:
- http-proxy-3 has 2 dependencies, its installation size is about 185 KiB (https://pkg-size.dev/http-proxy-3)
- httpxy has 0 dependency (!) and its installation size is only 57 KiB (https://pkg-size.dev/httpxy)
Though http-proxy-3 claims it is used by the Vite, httpxy is actually widely used by the Nuxt.js community, and is actually getting contributions from the Vite.js Team (refactor!: code improvements unjs/httpxy#78)!

Motivation and Context

See #1136

How has this been tested?

Unlike #1159, I actually get all the tests to pass and TypeScript happy! You can check the action log here: SukkaW#1

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.

SukkaW · 2026-02-07T20:46:12Z

cc @chimurai

Please check my PR as another attempt to fix #1136. Unlike #1159, I get all the tests to pass both on my machine locally and on CI (check SukkaW#1):

Also, I get rid of all TypeScript errors with tsc --build runs perfectly:

chimurai · 2026-02-07T22:10:50Z

Hi @SukkaW

Thanks for the PR! Didn't know about httpxy

Did a quick check and looks really nice so far. Most of the types are working.

Found a small issue in the typing where req somehow is now type any.

Added an extra check to prevent req: any (#1161)

🔧 Can you rebase with master?
You'll see the same error in:

http-proxy-middleware/test/types.spec.ts

Lines 393 to 401 in 6436ffc

    
           // responseInterceptor 
        
           proxyServer.on( 
        
             'proxyRes', 
        
             responseInterceptor(async (buffer, proxyRes, req, res) => { 
        
               req.params; 
        
               res.status(200).send('OK'); 
        
               return buffer; 
        
             }), 
        
           );

SukkaW · 2026-02-08T07:55:30Z

Did a quick check and looks really nice so far. Most of the types are working.

Found a small issue in the typing where req somehow is now type any.

The httpxy usage of EventEmitter is not typed. I have submitted a PR to the upstream to fix it: unjs/httpxy#96

After httpxy merges that PR and releases a new version, the any we are seeing here should be gone.

SukkaW · 2026-02-11T17:59:45Z

@chimurai

The types are fixed, and all tests passed on my machine locally:

SukkaW · 2026-02-11T18:07:22Z

@chimurai Also, I am currently actively working on httpxy's HTTP/2 listener support (unjs/httpxy#38).

Update: almost done unjs/httpxy#102

SukkaW · 2026-03-05T18:22:18Z

@chimurai Hello, what else is required for the PR to merge? All TypeScript error has been fixed and the lint is now happy.

SukkaW · 2026-04-02T13:47:12Z

@chimurai Just a friendly ping, would you like to review this? All TypeScript errors have been fixed, the lint is happy, and all the tests have passed.

coveralls · 2026-04-02T17:29:05Z

coverage: 96.544% (-0.6%) from 97.15%
when pulling eb2449c on SukkaW:replace-http-proxy
into bcf1864 on chimurai:master.

chimurai · 2026-04-02T17:36:33Z

Hi @SukkaW. Thanks for the reminder. PR looks good.

CI is failing because patches need to be removed which are not needed anymore:

patches/http-proxy+1.18.1.patch

You can verify if the other patches are still needed with:

yarn patch-package

Once this is fixed, this PR can be merged 👍

Copilot

Pull request overview

This PR attempts to resolve #1136 by replacing the unmaintained http-proxy dependency with httpxy, updating the middleware implementation and exported types to match httpxy’s API/behavior.

Changes:

Swap http-proxy / @types/http-proxy for httpxy and update lockfile/spellcheck dictionary.
Refactor core proxying logic to use httpxy’s promise-based web/ws APIs and adjust error handling + shutdown behavior.
Update public TypeScript types and response interception types to align with the new proxy library.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`package.json`	Replaces proxy dependency with `httpxy` (but note `patch-package` implications).
`yarn.lock`	Removes `http-proxy` transitive deps and adds `httpxy`.
`tsconfig.json`	Enables `skipLibCheck`.
`src/http-proxy-middleware.ts`	Migrates to `httpxy` (`createProxyServer`, async `web/ws`), adjusts error emitting and close handling.
`src/types.ts`	Switches exported proxy types from `http-proxy` to `httpxy` and redefines event callback shapes.
`src/plugins/default/proxy-events.ts`	Adjusts `on` option iteration to improve typing/narrowing.
`src/plugins/default/error-response-plugin.ts`	Changes error guard condition for rethrow behavior.
`src/handlers/response-interceptor.ts`	Corrects `proxyRes` typing to `http.IncomingMessage` and updates decompression call site.
`cspell.json`	Adds `httpxy` to allowed words list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SukkaW · 2026-04-03T06:11:28Z

cc @chimurai

I have rebased the PR to the latest master, and I have dropped patches/http-proxy+1.18.1.patch in dacea34 (this PR).

erictheswift · 2026-04-03T06:21:20Z

Kudos!

pkg-pr-new · 2026-04-03T08:14:06Z

npm i https://pkg.pr.new/http-proxy-middleware@1160

commit: 058d409

chimurai · 2026-04-03T21:57:52Z

Many thanks @SukkaW and @bjohansebas (with the previous attempt) for helping out with the upgrade.

Special thanks to @pi0 for the continuation of http-proxy with httpxy 🎉

You guys made a long waited upgrade possible 🙏

I published a beta version: npm i http-proxy-middleware@beta

Please let me know if there are any issues.

chimurai · 2026-04-04T07:55:20Z

Hi Sukka. Really good point. Definitely sense to take this opportunity. I'll update the roadmap 👍

…

On Sat, Apr 4, 2026 at 8:47 AM Sukka ***@***.***> wrote: *SukkaW* left a comment (chimurai/http-proxy-middleware#1160) <#1160 (comment)> I published a beta version: npm i ***@***.*** Please let me know if there are any issues. @chimurai <https://github.com/chimurai> Actually, if we are going into a new major version bump (v4) anyway, maybe it is possible to include the latest ***@***.*** in v4. After all, it is a golden opportunity to bump the Node.js support range. — Reply to this email directly, view it on GitHub <#1160 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE77COIVT3RHH7OOEIONBD4UCVXFAVCNFSM6AAAAACULABFGOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOBWGYYDGOBWGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

SukkaW mentioned this pull request Feb 7, 2026

feat: migrate from http-proxy to http-proxy alternative #1136

Closed

chimurai reviewed Feb 7, 2026

View reviewed changes

Comment thread tsconfig.json

SukkaW mentioned this pull request Feb 8, 2026

ProxyServer's event is not typed unjs/httpxy#95

Closed

SukkaW force-pushed the replace-http-proxy branch from b1801dd to c10521e Compare February 9, 2026 09:09

SukkaW commented Feb 11, 2026

View reviewed changes

Comment thread src/handlers/response-interceptor.ts

SukkaW commented Feb 11, 2026

View reviewed changes

Comment thread src/plugins/default/error-response-plugin.ts

jonatanschroeder mentioned this pull request Mar 19, 2026

Deprecation warning for http-proxy PrairieLearn/PrairieLearn#14472

Closed

bjohansebas mentioned this pull request Mar 31, 2026

feat: update http-proxy dependency to http-proxy-3 #1159

Closed

5 tasks

SukkaW requested a review from chimurai April 2, 2026 13:46

chimurai force-pushed the replace-http-proxy branch from 13848fb to 548b23c Compare April 2, 2026 17:26

chimurai requested a review from Copilot April 2, 2026 19:12

Copilot started reviewing on behalf of chimurai April 2, 2026 19:13 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

Comment thread src/types.ts

Comment thread package.json

Comment thread src/plugins/default/error-response-plugin.ts

bjohansebas reviewed Apr 2, 2026

View reviewed changes

Comment thread package.json

SukkaW force-pushed the replace-http-proxy branch from 548b23c to dacea34 Compare April 3, 2026 06:10

chimurai added this to the v4 milestone Apr 3, 2026

chimurai enabled auto-merge (squash) April 3, 2026 21:11

chimurai approved these changes Apr 3, 2026

View reviewed changes

SukkaW added 8 commits April 3, 2026 23:14

refactor(chimurai#1136): replace http-proxy w/ httpxy

3e41d3b

chore: make prettier happy

d6eab00

chore: make cspell happy

5b2250a

refactor: make tests passed

24b6640

chore: upgrade to latest httpxy and fix more types

56c75ea

refactor: make types happy

16063a6

chore: make lint happy

7786d53

chore: drop outdated patch-package

eb2449c

chimurai force-pushed the replace-http-proxy branch from dacea34 to eb2449c Compare April 3, 2026 21:14

chimurai merged commit 42d25d4 into chimurai:master Apr 3, 2026
10 checks passed

MirKml mentioned this pull request Apr 3, 2026

proxy doesn't work on connect type application with http2 webpack/webpack-dev-server#5549

Closed

This was referenced Apr 5, 2026

feat(deps): upgrade http-proxy-middleware to v4.0.0-beta.2 web-infra-dev/rsbuild#7436

Merged

feat(deps): upgrade http-proxy-middleware to v4.0.0-beta.2 rstackjs/rspack-dev-server#189

Closed

This was referenced Apr 19, 2026

nodejitsu/node-http-proxy is dead. Would you consider switching? #214

Closed

util api is deprecated #1131

Closed

Deprecation warnings when using node v22 #1058

Closed

Conversation

SukkaW commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

How has this been tested?

Types of changes

Checklist:

Uh oh!

SukkaW commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chimurai commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

SukkaW commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SukkaW commented Feb 11, 2026

Uh oh!

Uh oh!

Uh oh!

SukkaW commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SukkaW commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SukkaW commented Apr 2, 2026

Uh oh!

coveralls commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chimurai commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SukkaW commented Apr 3, 2026

Uh oh!

erictheswift commented Apr 3, 2026

Uh oh!

pkg-pr-new Bot commented Apr 3, 2026

Uh oh!

Uh oh!

chimurai commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chimurai commented Apr 4, 2026 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SukkaW commented Feb 7, 2026 •

edited

Loading

SukkaW commented Feb 7, 2026 •

edited

Loading

chimurai commented Feb 7, 2026 •

edited

Loading

SukkaW commented Feb 8, 2026 •

edited

Loading

SukkaW commented Feb 11, 2026 •

edited

Loading

SukkaW commented Mar 5, 2026 •

edited

Loading

coveralls commented Apr 2, 2026 •

edited

Loading

chimurai commented Apr 2, 2026 •

edited

Loading

chimurai commented Apr 3, 2026 •

edited

Loading