path can be empty string#110
Merged
chimurai merged 2 commits intochimurai:masterfrom Sep 20, 2016
Merged
Conversation
Owner
|
Please provide a description and test plan for this PR. |
Contributor
Author
|
@chimurai for example If I want to replace the whole path into an empty string, then it would complain "No rewritten path found" |
| var path = pathRewriter(req.url, req); | ||
|
|
||
| if (path) { | ||
| if (path !== false) { |
Owner
There was a problem hiding this comment.
Can you change the condition to:
if (typeof path === 'string') {
...
}
Owner
|
Testing for a |
Contributor
Author
|
Can it be merged now @chimurai |
Owner
|
Sorry for the late response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.