Repository navigation
fix(messages): make search_global pages different - #343
Merged
Merged
Conversation
messages.searchGlobal has no add_offset, which Telethon silently ignores for a global search, so page 2 and 3 returned the same messages as page 1 and older results were unreachable. Fetch up to the end of the requested page, letting Telethon page through the results, and keep only that page. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_018Xun6C4mXUAKbVSmiEEh79
chigwell
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search_globalpaginated withadd_offset=offset, butmessages.searchGlobaldoes not support an offset — Telethon silently ignores it for a global search, so every requested page returned the same first-page results.The fix fetches up to the end of the requested page (
limit=offset + page_size) and slices off everything beforeoffset, letting Telethon page through the result set itself. Page 1 behaves exactly as before.Testing
tests/test_search_global_pages.pyasserts page 2 differs from page 1.🤖 Generated with Claude Code