Skip to content

Commit 9a38e74

Browse files
chhabrakadabrakevjumba
authored andcommitted
Switch to google-cloud-bigquery[pandas].
This was covered in feast-dev#2537. I've only generated lockfiles for Python 3.8 to test this in CI. I'll do the same for the rest of the Python versions later. Signed-off-by: Abhin Chhabra <[email protected]> Signed-off-by: Kevin Zhang <[email protected]>
1 parent ca7028c commit 9a38e74

2 files changed

Lines changed: 18 additions & 10 deletions

File tree

‎sdk/python/requirements/py3.8-ci-requirements.txt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,6 @@ googleapis-common-protos==1.56.3
265265
# tensorflow-metadata
266266
great-expectations==0.14.13
267267
# via feast (setup.py)
268-
greenlet==1.1.2
269-
# via sqlalchemy
270268
grpcio==1.47.0
271269
# via
272270
# feast (setup.py)

‎setup.py‎

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -427,12 +427,18 @@ def build_extension(self, ext: Extension):
427427
print(f"CWD: {os.getcwd()}")
428428

429429
destination = os.path.dirname(os.path.abspath(self.get_ext_fullpath(ext.name)))
430-
subprocess.check_call(["go", "install", "golang.org/x/tools/cmd/goimports"],
431-
env={"PATH": bin_path, **go_env})
432-
subprocess.check_call(["go", "get", "github.com/go-python/[email protected]"],
433-
env={"PATH": bin_path, **go_env})
434-
subprocess.check_call(["go", "install", "github.com/go-python/gopy"],
435-
env={"PATH": bin_path, **go_env})
430+
subprocess.check_call(
431+
["go", "install", "golang.org/x/tools/cmd/goimports"],
432+
env={"PATH": bin_path, **go_env},
433+
)
434+
subprocess.check_call(
435+
["go", "get", "github.com/go-python/[email protected]"],
436+
env={"PATH": bin_path, **go_env},
437+
)
438+
subprocess.check_call(
439+
["go", "install", "github.com/go-python/gopy"],
440+
env={"PATH": bin_path, **go_env},
441+
)
436442
subprocess.check_call(
437443
[
438444
"gopy",
@@ -442,12 +448,16 @@ def build_extension(self, ext: Extension):
442448
"-vm",
443449
sys.executable,
444450
"--build-tags",
445-
'cgo,ccalloc',
451+
"cgo,ccalloc",
446452
"--dynamic-link=True",
447453
"-no-make",
448454
*ext.sources,
449455
],
450-
env={"PATH": bin_path, "CGO_LDFLAGS_ALLOW": ".*", **go_env,},
456+
env={
457+
"PATH": bin_path,
458+
"CGO_LDFLAGS_ALLOW": ".*",
459+
**go_env,
460+
},
451461
)
452462

453463
def copy_extensions_to_source(self):

0 commit comments

Comments
 (0)