Repository navigation
Fix macOS portable ZIP library relocation and signatures - #9
Merged
thomasc1971 merged 1 commit intoOct 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS portable packager edits dylib install names after copying them, invalidating their existing signatures. It also leaves transitive dependencies pointing to the build machine and allows inherited Homebrew rpaths to take precedence over bundled libraries.
This collects the complete dependency graph before editing, rewrites non-system load commands to paths within the bundle, removes inherited rpaths, and ad-hoc signs and strictly verifies every Mach-O after the final modifications. Missing dependencies and conflicting library basenames now stop packaging instead of producing an incomplete ZIP. The Windows branch is unchanged.
The macOS workflow now extracts the ZIP, verifies its Mach-O signatures, and runs both --version and the existing GUI smoke test through the packaged launcher.
Fixes #8.
Validation on macOS 26.7 arm64:
The local application build disables optional ThorVG support; the existing CI dependency setup still includes ThorVG. The packager handles the absolute dependency paths used by the current build and fails explicitly on unresolved tokenized source dependencies. This does not add Developer ID signing or notarization.