Skip to content

Make onetrust key configurable#3771

Merged
jashaik merged 3 commits intomainfrom
onetrust-config
Mar 11, 2024
Merged

Make onetrust key configurable#3771
jashaik merged 3 commits intomainfrom
onetrust-config

Conversation

@ayush-billore
Copy link
Copy Markdown
Contributor

@ayush-billore ayush-billore commented Feb 1, 2024

Description

Make onetrust ID configurable

Demo - link

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@ayush-billore ayush-billore requested review from a team as code owners February 1, 2024 08:41
@netlify
Copy link
Copy Markdown

netlify bot commented Feb 1, 2024

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit 1841553
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/65eea6b3d2605e0008e7ae04

@ayush-billore ayush-billore force-pushed the onetrust-config branch 2 times, most recently from 9b3de7b to 7d2a35c Compare February 6, 2024 05:27

`oc_id['onetrust_id']`

: The Onetrust ID for Chef Infra. You must also set `oc_id['enable_onetrust']` to `true`.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: The Onetrust ID for Chef Infra. You must also set `oc_id['enable_onetrust']` to `true`.
: The OneTrust data domain script ID for Chef Infra. You must also set `oc_id['enable_onetrust']` to `true`.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chef-server current version is 15.9.20 we have 3 more probable PR's to merge, we can keep it 15.9.22 for now and we will change it in release.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @sreepuramsudheer I will add 15.9.22. Thanks!

@ayush-billore
Copy link
Copy Markdown
Contributor Author

@IanMadd I have made the changes as requested, please re review

@sreepuramsudheer
Copy link
Copy Markdown
Contributor

Signed-off-by: ayush-billore <[email protected]>
Signed-off-by: ayush-billore <[email protected]>
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqube-for-infrastructure-prod
Copy link
Copy Markdown

@jashaik jashaik merged commit 54e5bc5 into main Mar 11, 2024
@jashaik jashaik deleted the onetrust-config branch March 11, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants