Skip to content

[CHEF-6100 CHEF-6112] GTM and OneTrust changes#3738

Merged
sreepuramsudheer merged 2 commits intomainfrom
gtm-onetrust-changes
Jan 2, 2024
Merged

[CHEF-6100 CHEF-6112] GTM and OneTrust changes#3738
sreepuramsudheer merged 2 commits intomainfrom
gtm-onetrust-changes

Conversation

@ayush-billore
Copy link
Copy Markdown
Contributor

@ayush-billore ayush-billore commented Nov 15, 2023 •
edited by sreepuramsudheer
Loading

Description

  • Add onetrust
  • Add GTM

https://chefio.atlassian.net/browse/CHEF-6100
https://chefio.atlassian.net/browse/CHEF-6112

ocid-gtm-ot.mov

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@ayush-billore ayush-billore requested review from a team as code owners November 15, 2023 10:37
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for chef-server ready!

Name Link
🔨 Latest commit 63da7b9
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/658d5499b1d6ac0008fead5c
😎 Deploy Preview https://deploy-preview-3738--chef-server.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ayush-billore ayush-billore changed the title [CHEF-6100 CHEF-6112] GTM and OneTrust changes [WIP][CHEF-6100 CHEF-6112] GTM and OneTrust changes Nov 15, 2023
@ayush-billore ayush-billore marked this pull request as draft November 15, 2023 10:38
@ayush-billore ayush-billore changed the title [WIP][CHEF-6100 CHEF-6112] GTM and OneTrust changes [CHEF-6100 CHEF-6112] GTM and OneTrust changes Nov 15, 2023
@ayush-billore ayush-billore force-pushed the gtm-onetrust-changes branch 2 times, most recently from 4eb8ec7 to a4bd295 Compare November 22, 2023 07:42
@ayush-billore ayush-billore marked this pull request as ready for review December 1, 2023 08:15
@ayush-billore ayush-billore self-assigned this Dec 1, 2023
@ayush-billore ayush-billore force-pushed the gtm-onetrust-changes branch 3 times, most recently from 91dd619 to 4f43770 Compare December 1, 2023 08:31
@ayush-billore ayush-billore force-pushed the gtm-onetrust-changes branch 3 times, most recently from 4599082 to 3919149 Compare December 11, 2023 14:17
@ayush-billore ayush-billore requested a review from a team as a code owner December 13, 2023 10:57
marcparadise
marcparadise requested changes Dec 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be very careful adding any kind of analytics in this space, and very clear that this is disabled by default and only enabled when configured.

To help with that the commit message and the PR should include wording to the effect of:

Add support for Google Tag Manager and OneTrust to oc-id.

Both are disabled by default and must be explicitly enabled in server configuration."

Please squash commits and rebase.

@ayush-billore
Copy link
Copy Markdown
Contributor Author

ayush-billore commented Dec 14, 2023

We need to be very careful adding any kind of analytics in this space, and very clear that this is disabled by default and only enabled when configured.

To help with that the commit message and the PR should include wording to the effect of:

Add support for Google Tag Manager and OneTrust to oc-id.

Both are disabled by default and must be explicitly enabled in server configuration."

Please squash commits and rebase.

Thanks mark for the suggestion, this message clearly conveys the intention of the work.
I will make the changes . Thanks!

@ayush-billore ayush-billore force-pushed the gtm-onetrust-changes branch 2 times, most recently from a09befc to 6d7a0b6 Compare December 14, 2023 14:10
@IanMadd
Copy link
Copy Markdown
Contributor

IanMadd commented Dec 14, 2023

What versions of server is this going to be released in? Just the latest version of 15.x?

@karunesh-tech
Copy link
Copy Markdown
Collaborator

karunesh-tech commented Dec 15, 2023

Hi @jashaik
Can we please merge this if there is nothing pending on this one. We need to proceed with dev-complete status for GDPR activity, this closure will help us to update other stakeholders for the same.

@ayush-billore
Copy link
Copy Markdown
Contributor Author

ayush-billore commented Dec 15, 2023

What versions of server is this going to be released in? Just the latest version of 15.x?

@jashaik @marcparadise @kalroy @karunesh-tech

@jashaik
Copy link
Copy Markdown
Contributor

jashaik commented Dec 15, 2023

What versions of server is this going to be released in? Just the latest version of 15.x?

@IanMadd it will be a patch release of 15.9 chef-server.

@IanMadd IanMadd added the Documentation Pulls PR onto docs board so they know it exists label Dec 19, 2023
@IanMadd IanMadd mentioned this pull request Dec 19, 2023
Merged
5 tasks
@IanMadd
Copy link
Copy Markdown
Contributor

IanMadd commented Dec 19, 2023

@ayush-billore See changes in #3757. You can delete the docs changes in this one. I included them in 3757.

ayush-billore and others added 2 commits December 28, 2023 16:27
@ayush-billore @RoyShravani
Add support for Google Tag Manager and OneTrust to oc-id. Both are di…
2d43c85 
…sabled by default and must be explicitly enabled in server configuration.

Signed-off-by: ayush-billore <[email protected]>
@RoyShravani
removing doc changes
63da7b9 
Signed-off-by: Shravani Roy <[email protected]>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
1 Security Hotspot
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqube-for-infrastructure-prod
Copy link
Copy Markdown

sonarqube-for-infrastructure-prod bot commented Dec 28, 2023

SonarQube Quality Gate

Quality Gate failed

Failed condition B Reliability Rating on New Code (is worse than A)
Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)
0.0% 0.0% Security Hotspots Reviewed on New Code (is less than 100%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@RoyShravani RoyShravani removed the Documentation Pulls PR onto docs board so they know it exists label Dec 28, 2023
@sreepuramsudheer
Copy link
Copy Markdown
Contributor

sreepuramsudheer commented Dec 28, 2023

Adhoc build: https://buildkite.com/chef/chef-chef-server-main-omnibus-adhoc/builds/6064

@sreepuramsudheer sreepuramsudheer merged commit cdef8b4 into main Jan 2, 2024
@sreepuramsudheer sreepuramsudheer deleted the gtm-onetrust-changes branch January 2, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jashaik jashaik jashaik approved these changes

@saghoshprogress saghoshprogress saghoshprogress approved these changes

@RajeshPaul38 RajeshPaul38 Awaiting requested review from RajeshPaul38

@RoyShravani RoyShravani Awaiting requested review from RoyShravani

@marcparadise marcparadise Awaiting requested review from marcparadise

Assignees

@ayush-billore ayush-billore

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ayush-billore @IanMadd @karunesh-tech @jashaik @sreepuramsudheer @marcparadise @saghoshprogress @RoyShravani